[
https://issues.apache.org/jira/browse/OAK-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15608432#comment-15608432
]
Alex Parvulescu commented on OAK-5004:
--------------------------------------
wrt. compaction predicate. I agree, but you should also remove
{{OfflineCompactionPredicate}} completely if it's not being used.
More about binaries. If we are talking about a setup that uses an external
datastore, then you are cutting the cache in half and basically never using one
of these 2 halves. so if you decide to ignore external binaries, it might be
better to allocate a lot more (90%) to the nodes cache.
More about external binaries. I guess this change would affect checkpoints the
most, you'd be basically multiplying the binary record ids by the number of
checkpoints, and if it's an asset heavy deployment, this can add up. I don't
have any numbers though so if you're ok with this, we can pick this up again
later if needed.
> Offline compaction explodes checkpoints
> ----------------------------------------
>
> Key: OAK-5004
> URL: https://issues.apache.org/jira/browse/OAK-5004
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: compaction, gc, tooling
> Fix For: 1.6, 1.5.14
>
> Attachments: OAK_5004.patch
>
>
> Running offline compaction on a repository with checkpoints will explode
> those into full copies. Observed e.g. with OAK-5001.
> I think we should consider improving this by compacting checkpoints on top of
> each other in the proper order ({{oak-upgrade}} does this successfully).
> [~alex.parvulescu], WDYT? What was our take on this in the previous Oak
> versions?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
