[ 
https://issues.apache.org/jira/browse/OAK-5030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628177#comment-15628177
 ] 

Michael Dürig commented on OAK-5030:
------------------------------------

Agreed. A better name for {{NodeBuilder#getNodeState()}} would have been 
{{.buildNodeState()}}, implying that there is actual work being done. The 
intended usage pattern for {{NodeBuilders}} actually is acquire, modify, build, 
throw away. However, unfortunately this is not properly reflected in its 
methods and their semantics. 

Bottom line: side effect should be explicit!

> Copying the versions store is slow and increase the repository size
> -------------------------------------------------------------------
>
>                 Key: OAK-5030
>                 URL: https://issues.apache.org/jira/browse/OAK-5030
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: upgrade
>            Reporter: Michael Dürig
>            Assignee: Tomek Rękawek
>              Labels: perfomance
>             Fix For: 1.6, 1.5.13
>
>         Attachments: OAK-5030-2.patch, OAK-5030.patch
>
>
> This is a follow up to OAK-4970: when defining an workspace name that doesn't 
> match the name of the workspace of the source repository (via the 
> {{WORKSPACE_NAME_PROP}} system property), upgrading is still very slow and 
> causes the repository size to grow way too much. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to