[
https://issues.apache.org/jira/browse/OAK-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger updated OAK-5079:
----------------------------------
Attachment: OAK-5079-v2.patch
I updated the patch with some minor modification:
- There's an unused import in a test
- Removed duplicate methods in DocumentBundlingTest now available in TestUtils
- Moved asDocumentNodeState() to TestUtils
- BundledDocumentDiffer contains a JavaDoc link to DelegatingDocumentNodeState
which cannot be resolved. This will fail JavaDoc generation with Java 8. I
replaced it with a simple code link.
Other than that, I think the patch looks good.
> Diff would not work for bundled nodes when done without journal support
> -----------------------------------------------------------------------
>
> Key: OAK-5079
> URL: https://issues.apache.org/jira/browse/OAK-5079
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-5079-v1.diff, OAK-5079-v2.patch
>
>
> DocumentNodeState.diff logic relies on fact that all child nodes for any
> given path are represented as NodeDocument. This would not work if we have
> bundled child nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
