[
https://issues.apache.org/jira/browse/OAK-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Parvulescu resolved OAK-5117.
----------------------------------
Resolution: Fixed
thanks for the patch! fixed with
http://svn.apache.org/viewvc?rev=1770010&view=rev
> Improve checkMemory for compaction
> ----------------------------------
>
> Key: OAK-5117
> URL: https://issues.apache.org/jira/browse/OAK-5117
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Valentin Olteanu
> Assignee: Alex Parvulescu
> Fix For: 1.6, 1.5.14
>
> Attachments: OAK-5117-v2.patch, OAK-5117.patch
>
>
> The check introduced in OAK-4966 is relying on the first {{MemoryPoolMXBean}}
> found that matches the criteria. This means that, depending on the JVM, it
> will be checking any of the: PS Eden Space, PS Survivor Space or PS Old Gen
> Space - whichever is found first.
> I am proposing a more reliable way to check this:
> 1. check the biggest pool - this usually corresponds to PS Old Gen (by
> default 2/3 of the heap), which is more stable and reflects better the usage
> of the heap.
> 2. use {{getCollectionUsage()}} instead of {{getUsage()}} to check the state
> of the heap after a GC. This way we avoid checking during temporary peaks of
> the used heap.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
