[
https://issues.apache.org/jira/browse/OAK-4939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15687067#comment-15687067
]
Alex Parvulescu commented on OAK-4939:
--------------------------------------
Patch looks good!
A question regarding the warning {{Ignoring corrupt index [{}] which has been
marked as corrupt since [{}].}} Will this be logged each indexing cycle (5
seconds)? seems a bit verbose.
And a minor thing, can you quickly revisit the logs? I have a few instances
that need more love:
{quote}
log.debug("Failing index at [{}] is already marked as corrupt. The index is
failing {}");
{quote}
-> missing params
{quote}
log.info("Auto corrupt index isolation handling is enabled. Any async index
which fails for [{}]s would " +
"be marked as corrupted and would be skipped from further indexing");
{quote}
-> missing params
{quote}
log.info("Removing corrupt flag from index [{}] which has been marked " +
"as corrupt since [{}]", indexPath, corrupt);
{quote}
-> doesn't format the property as in the other cases, will only do a simple
toString on it
> Isolate corrupted index and make async indexer more resilient
> -------------------------------------------------------------
>
> Key: OAK-4939
> URL: https://issues.apache.org/jira/browse/OAK-4939
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene, query
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6, 1.5.15
>
> Attachments: OAK-4939-v1.diff, OAK-4939-v2.diff,
> corrupt-index-mbean.png
>
>
> Currently if any one of the async index gets corrupted it brings down the
> whole async indexer and no other index gets updated untill system
> administrator reindexes the problamatic async index.
> Instead of fail all we should isolate such corrupted index and mark them as
> corrupted. And still let async indexer progress for other working indexes.
> This would ensure that one corrupted index does not affect the whole system
> and allow the application to work partially.
> Feature branch -
> https://github.com/chetanmeh/jackrabbit-oak/compare/trunk...chetanmeh:OAK-4939?expand=1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
