[ 
https://issues.apache.org/jira/browse/OAK-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15690397#comment-15690397
 ] 

Michael Dürig commented on OAK-5130:
------------------------------------

+1, good catch! This simplification have been mad possible by the change in 
OAK-4631

> Prevent FileStore wrapping the segment buffer twice for the generation info
> ---------------------------------------------------------------------------
>
>                 Key: OAK-5130
>                 URL: https://issues.apache.org/jira/browse/OAK-5130
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Alex Parvulescu
>             Fix For: 1.6, 1.5.15
>
>         Attachments: OAK-5130.patch
>
>
> It seems the FileStore#writeSegment method will wrap the buffer a second time 
> to extract the generation info [0], information which only applies to data 
> segments and should already be available.
> [0] 
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java#L621



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to