[
https://issues.apache.org/jira/browse/OAK-4898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15693494#comment-15693494
]
Marcel Reutegger commented on OAK-4898:
---------------------------------------
I think your changes break the build. I see the following error:
{noformat}
compactionCausesRefresh[0](org.apache.jackrabbit.oak.jcr.RefreshOnGCTest) Time
elapsed: 1.106 sec <<< ERROR!
java.lang.NullPointerException
at
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:192)
at
org.apache.jackrabbit.oak.spi.commit.ChangeDispatcher.contentChanged(ChangeDispatcher.java:79)
at
org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStore.refreshHead(SegmentNodeStore.java:257)
at
org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStore.getRoot(SegmentNodeStore.java:273)
at
org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStore.reset(SegmentNodeStore.java:350)
at
org.apache.jackrabbit.oak.core.MutableRoot.refresh(MutableRoot.java:235)
at
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.refresh(SessionDelegate.java:508)
at
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.prePerform(SessionDelegate.java:611)
at
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:205)
at
org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
at
org.apache.jackrabbit.oak.jcr.session.NodeImpl.hasNode(NodeImpl.java:829)
at
org.apache.jackrabbit.oak.jcr.RefreshOnGCTest.compactionCausesRefresh(RefreshOnGCTest.java:170)
{noformat}
> Allow for external changes to have a CommitInfo attached
> --------------------------------------------------------
>
> Key: OAK-4898
> URL: https://issues.apache.org/jira/browse/OAK-4898
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-4898-v1.patch, OAK-4898-v2.patch, OAK-4898-v3.patch,
> OAK-4898-v4.patch
>
>
> Currently the observation logic relies on fact that CommitInfo being null
> means that changes are from other cluster node i.e. external changes.
> We should change this semantic and provide a different way to indicate that
> changes are external. This would allow a NodeStore implementation to still
> pass in a CommitInfo which captures useful information about commit like
> brief summary on what got changed which can be used for pre filtering
> (OAK-4796)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
