[
https://issues.apache.org/jira/browse/OAK-5160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15704748#comment-15704748
]
Marcel Reutegger commented on OAK-5160:
---------------------------------------
I'm also in favour of this change. Is there a specific reason why the patch
comments out some of the expected Pairs? Wouldn't it be cleaner if the lines
were simply removed? The issue title and description should also be updated to
reflect the intended change. Otherwise +1 ;)
> change Nonnull to Nullable in FilteringAwareObserver.contentChanged
> -------------------------------------------------------------------
>
> Key: OAK-5160
> URL: https://issues.apache.org/jira/browse/OAK-5160
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.5.14
> Reporter: Stefan Egli
> Assignee: Stefan Egli
> Fix For: 1.6, 1.5.15
>
> Attachments: OAK-5160.patch
>
>
> FilteringAwareObserver (and thus ChangeProcessor)'s {{contentChanged}} has
> {{@Nonnull}} for the {{before}} parameter. But for the very first
> contentChanged (at initialization time) this can actually be null. So we
> should change that to {{@Nullable}} there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
