[
https://issues.apache.org/jira/browse/OAK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15709225#comment-15709225
]
angela edited comment on OAK-4930 at 11/30/16 5:43 PM:
-------------------------------------------------------
[~baedke], changed back to Improvement as discussed on the phone... I really
don't think this was a bug. And btw: if it was a performance improvement as you
stated in the private discussion, I would have appreciated if you had attached
some numbers and created a benchmark illustrating the issue and the gain
associated with your proposed changes.
Do you want to provide the after the fact here or shall I create another issue
for that?
was (Author: anchela):
[~baedke], changed back to Improvement as discussed on the phone... I really
don't think this was a bug. And btw: if it was a performance improvement as you
stated in the private discussion, I would have appreciated if you had attached
some numbers and created a benchmark illustrating the issue and the gain
associated with your proposed changes.
> External Principal Management: DynamicSyncContext makes redundant calls to
> IdentityProvider.getIdentity()
> ----------------------------------------------------------------------------------------------------------
>
> Key: OAK-4930
> URL: https://issues.apache.org/jira/browse/OAK-4930
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Affects Versions: 1.4.8, 1.2.20, 1.5.12
> Reporter: Manfred Baedke
> Assignee: Manfred Baedke
> Fix For: 1.6, 1.4.9, 1.5.13
>
>
> When recursively collecting principal names associated with the declared
> group memberships of a given principal, the method
> DynamicSyncContext.collectPrincipalNames() unnecessarily calls
> IdentityProvider.getIdentity() for every declared group reference, though it
> is only necessary when the actual depth of the remaining recursion is >1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
