[ 
https://issues.apache.org/jira/browse/OAK-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Mari updated OAK-5289:
--------------------------------
    Description: 
The {{tarmkdiff}} command is actually the combination of two commands. 

The first command, activated when the {{\-\-list}} flag is specified, list 
available revisions in the Segment Store. For this command, only the 
{{\-\-output}} option is relevant. If other options are specified, they are 
ignored.

The second command is the proper logic of {{tarmkdiff}}. This logic is 
activated only if the {{\-\-list}} flag is not specified. For this command, 
every option on the command line is relevant.

The logic listing available revisions in the Segment Store should be 
encapsulated in its own command, without cluttering the CLI of {{tarmkdiff}}.

  was:
The {{tarmkdiff}} command is actually the combination of two commands. 

The first command, activated when the {{\-\-list}} flag is specified, list 
available revisions in the Segment Store. For this command, only the 
{{\-\-path}} option is relevant. If other options are specified, they are 
ignored.

The second command is the proper logic of {{tarmkdiff}}. This logic is 
activated only if the {{\-\-list}} flag is not specified. For this command, 
every option on the command line is relevant.

The logic listing available revisions in the Segment Store should be 
encapsulated in its own command, without cluttering the CLI of {{tarmkdiff}}.


> The tarmkdiff command does too many things
> ------------------------------------------
>
>                 Key: OAK-5289
>                 URL: https://issues.apache.org/jira/browse/OAK-5289
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run, segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Minor
>             Fix For: 1.6
>
>
> The {{tarmkdiff}} command is actually the combination of two commands. 
> The first command, activated when the {{\-\-list}} flag is specified, list 
> available revisions in the Segment Store. For this command, only the 
> {{\-\-output}} option is relevant. If other options are specified, they are 
> ignored.
> The second command is the proper logic of {{tarmkdiff}}. This logic is 
> activated only if the {{\-\-list}} flag is not specified. For this command, 
> every option on the command line is relevant.
> The logic listing available revisions in the Segment Store should be 
> encapsulated in its own command, without cluttering the CLI of {{tarmkdiff}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to