[
https://issues.apache.org/jira/browse/OAK-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15748678#comment-15748678
]
Michael Dürig commented on OAK-5293:
------------------------------------
At http://svn.apache.org/viewvc?rev=1774277&view=rev I fixed a potential
{{null}} dereference in {{MapRecord.compare(MapRecord, NodeStateDiff)}} by
asserting the respective {{MapEntry}} instances and their values are not
{{null}}, which according to my reasoning is always the case here.
The tricky bit is {{beforeEntry.getValue()}}. AFAICS this cannot be {{null}}
as otherwise we would have gone (and returned from) one of the {{isDiff()}}
branches further up in the code.
> Static code analysis and code cleanup
> -------------------------------------
>
> Key: OAK-5293
> URL: https://issues.apache.org/jira/browse/OAK-5293
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: segment-tar
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: technical_debt
> Fix For: 1.5.17
>
>
> We should run some static analysis (i.e. sonar, find bugs, etc.) on our code
> base and fix the most sever issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
