Michael Dürig created OAK-5355:
----------------------------------

             Summary: Too eager refreshing of tree permissions in 
SecureNodeBuilder
                 Key: OAK-5355
                 URL: https://issues.apache.org/jira/browse/OAK-5355
             Project: Jackrabbit Oak
          Issue Type: Improvement
          Components: core
            Reporter: Michael Dürig
             Fix For: 1.8


{{SecureNodeBuilder.baseChanged()}} calls 
{{SecureNodeBuilder.getTreePermission()}} even though the tree permission would 
be calculated lazily as needed anyway. Re-calculating the tree permissions at 
this point bears the risk of accessing stale data from the underlying not yet 
fully refreshed root (when being called e.g. from {{MutableRoot.refresh()}}. 

I would thus argue for removing the call to 
{{SecureNodeBuilder.getTreePermission()}} from 
{{SecureNodeBuilder.baseChanged()}}. 

See also OAK-5296 for an in-depth analysis. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to