[
https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulceanu updated OAK-5604:
---------------------------------
Attachment: OAK-5604.patch
I decided that adding an additional warning when using {{--bin LENGTH}} is
useless since the usage instructions already show that no argument should be
provided:
{code}
--bin read the content of binary properties
{code}
as opposed to the previous instructions:
{code}
--bin <Long> read the first n bytes from binary properties.
{code}
Thus, the goal to fail fast if an argument is provided is met.
[~frm], could you take a look at the patch attached?
/cc [~mduerig]
> The check command should accept a non-argument "bin" option for checking
> binaries
> ---------------------------------------------------------------------------------
>
> Key: OAK-5604
> URL: https://issues.apache.org/jira/browse/OAK-5604
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: run, segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Labels: tooling
> Fix For: 1.8, 1.6.1
>
> Attachments: OAK-5604.patch
>
>
> Currently the {{--bin}} option expects a {{Long}} argument, as the {{LENGTH}}
> up to which to scan the content of binary properties. The {{--bin}} option
> should be simplified so that it doesn't take any arguments. Running {{check}}
> without the {{--bin}} flag won't scan any binary properties, while including
> {{--bin}} option will scan all binaries, no matter their size.
> If an argument is given with {{--bin}}, there will be a failure and a warning
> will be displayed.
> The message displayed at the end of the consistency check will be changed to
> take into account whether binary properties were traversed or not.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
