[
https://issues.apache.org/jira/browse/OAK-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15858181#comment-15858181
]
Francesco Mari commented on OAK-5604:
-------------------------------------
[~dulceanu], the patch looks good to me. The only remark is that we should
consider treating {{binLen}} as a boolean variable (instead of as a long
variable) in {{CheckCommand}}, {{ConsistencyChecker}} and {{Check}}. This would
simplify the code a bit.
I also have another comment that is not strictly related to this issue, but I
will write it down anyway. The {{fullTraversal}} option accepted by the command
backend is always {{true}}. As such, we should remove this option and any dead
code from the command backend. If there is already an issue that can be related
to this comment, I would be happy to delete stuff myself. Otherwise, I will
open another issue.
> The check command should accept a non-argument "bin" option for checking
> binaries
> ---------------------------------------------------------------------------------
>
> Key: OAK-5604
> URL: https://issues.apache.org/jira/browse/OAK-5604
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: run, segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Labels: tooling
> Fix For: 1.8, 1.6.1
>
> Attachments: OAK-5604.patch
>
>
> Currently the {{--bin}} option expects a {{Long}} argument, as the {{LENGTH}}
> up to which to scan the content of binary properties. The {{--bin}} option
> should be simplified so that it doesn't take any arguments. Running {{check}}
> without the {{--bin}} flag won't scan any binary properties, while including
> {{--bin}} option will scan all binaries, no matter their size.
> If an argument is given with {{--bin}}, there will be a failure and a warning
> will be displayed.
> The message displayed at the end of the consistency check will be changed to
> take into account whether binary properties were traversed or not.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
