[ 
https://issues.apache.org/jira/browse/OAK-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857727#comment-15857727
 ] 

Andrei Dulceanu edited comment on OAK-5595 at 2/9/17 12:27 PM:
---------------------------------------------------------------

Attaching a new patch with a simpler fix, without the refactoring initially 
proposed. This will be tackled in OAK-5620, after adding some test coverage for 
{{CheckCommand}} (tracked in OAK-5600).

[~mduerig], could you take a look at the new patch?


was (Author: dulceanu):
Attaching a new patch with a simpler fix, without the refactoring initially 
proposed. This will be tackled in OAK-5556, after adding some test coverage for 
{{CheckCommand}} (tracked in OAK-5600).

[~mduerig], could you take a look at the new patch?

> The check command should do deep traversals by default
> ------------------------------------------------------
>
>                 Key: OAK-5595
>                 URL: https://issues.apache.org/jira/browse/OAK-5595
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run, segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>              Labels: tooling
>             Fix For: 1.7.0, 1.8, 1.6.1
>
>         Attachments: OAK-5595-02.patch, OAK-5595.patch
>
>
> Only checking accessibility of the root nodes doesn't make much sense. Even 
> more so because the file store automatically rolls back on startup if a root 
> revision is not accessible. In terms of not doing full traversals, it is more 
> interesting to restrict by path (aka OAK-5556).
> The {{--deep}} option will still be accepted, but there will be a failure 
> when it is specified. An explanation that full traversal is now done 
> regardless of that option will be printed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to