[
https://issues.apache.org/jira/browse/OAK-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956584#comment-15956584
]
angela commented on OAK-6035:
-----------------------------
[~rombert], thanks a lot for spotting and the patch.
as far as {{AbstractLoginModule}} is concerned this is definitely true... it's
a base implementation of the {{LoginModule}} providing functionality shared by
multiple login modules within and possibly without Jackrabbit Oak.
when it comes to the {{Authentication}} interface it is may be implemented by
someone building a custom {{LoginModule}} but there is no requirement
whatsoever to do this. [~rombert] if that is still in alignment with the
provider type notion, I am all for committing the patch.
> Mark AbstractLoginModule and Authentication as provider types
> -------------------------------------------------------------
>
> Key: OAK-6035
> URL: https://issues.apache.org/jira/browse/OAK-6035
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: security
> Affects Versions: 1.7.0, 1.8
> Reporter: Robert Munteanu
> Attachments:
> 0001-OAK-6035-Mark-AbstractLoginModule-and-Authentication.patch
>
>
> With OAK-5903 the {{AbstractLoginModule}} and {{Authentication}} interfaces
> received new methods and the exported package version was bumped from 1.1.0
> to 2..0.0. This is unfortunately a breaking change for anyone importing the
> {{org.apache.jackrabbit.oak.spi.security.authentication}}, including Sling's
> oak-server module.
> To me these classes do not look as they are usually implemented by clients,
> but part of an SPI implemented mostly by oak-core, e.g. they are 'provider
> types' in OSGi vocabulary.
> I've marked them with the {{@ProviderType}} annotation which allows the
> exported package version to only be increased to 1.2.0 and allows consumer to
> reference those packages without changing import ranges across all Oak
> version.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
