[
https://issues.apache.org/jira/browse/OAK-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960686#comment-15960686
]
Alex Parvulescu commented on OAK-6001:
--------------------------------------
I think there's a method that was forgotten here, the FileStore's
GarbageCollector#collectBulkReferences seems unused? [0]
[0]
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java#L858
> Remove unused code from FileStore and TarWriter
> -----------------------------------------------
>
> Key: OAK-6001
> URL: https://issues.apache.org/jira/browse/OAK-6001
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Fix For: 1.7.0, 1.8
>
>
> {{FileStore.GarbageCollector#collectBulkReferences}} looks into the currently
> active {{TarWriter}} for references. At the time this method is invoked, the
> currently active {{TarWriter}} is always empty.
> Slightly before inspecting the {{TarWriter}}, {{FileStore#newWriter}} is
> called to flush the content of the current {{TarWriter}} and to create a
> fresh one. For this reason, inspecting the {{TarWriter}} in
> {{FileStore.GarbageCollector#collectBulkReferences}} is unnecessary - the
> graph of the {{TarWriter}} is always empty. Those lines of code can be safely
> removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
