[
https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986884#comment-15986884
]
Julian Sedding edited comment on OAK-6136 at 4/27/17 4:01 PM:
--------------------------------------------------------------
[~rombert] what about the following
- move {{SimpleMountInfoProvider}} and {{MountInfo}} to {{o.a.j.oak.spi.mount}}
with package private access
- move {{SimpleMountInfoProvider.Builder}} to {{Mounts.Builder}} and
{{SimpleMountInfoProvider.newBuilder()}} to {{Mounts.builder()}}
- add a method to the {{Builder}} to support {{pathsSupportingFragments}} and
refactor usages accordingly
I think having a simple way to build {{MountInfoProvider}}s fits into the
{{Mounts}} class and we hide {{SimpleMountInfoProvider}} and {{MountInfo}}. As
a side-effect we can get rid of the awkward dependency from {{oak-core}} and
{{oak-lucene}} to {{oak-multiplex}}.
WDYT? I'm happy to commit these changes. I can also attach a patch, but it's
noisy due to changes in all consumers of {{SimpleMountInfoProvider}}.
was (Author: jsedding):
[~rombert] what about the following
- move SimpleMountInfoProvider and MountInfo to o.a.j.oak.spi.mount with
package private access
- move {{SimpleMountInfoProvider.Builder}} to {{Mounts.Builder}} and
{{SimpleMountInfoProvider.newBuilder()}} to {{Mounts.builder()}}
- add a method to the {{Builder}} to support {{pathsSupportingFragments}} and
refactor usages accordingly
I think having a simple way to build {{MountInfoProvider}}s fits into the
{{Mounts}} class and we hide {{SimpleMountInfoProvider}} and {{MountInfo}}. As
a side-effect we can get rid of the awkward dependency from {{oak-core}} and
{{oak-lucene}} to {{oak-multiplex}}.
WDYT? I'm happy to commit these changes. I can also attach a patch, but it's
noisy due to changes in all consumers of {{SimpleMountInfoProvider}}.
> Extract the multiplexing implementation code into a separate bundle
> -------------------------------------------------------------------
>
> Key: OAK-6136
> URL: https://issues.apache.org/jira/browse/OAK-6136
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: Robert Munteanu
> Fix For: 1.8
>
> Attachments:
> 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch
>
>
> Since we already kicked off the m12n effort for 1.8 it would be good to
> separate the multiplexing implementation from oak-core into its own bundle as
> well.
> I will look into providing a patch for the change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
