[
https://issues.apache.org/jira/browse/OAK-5893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988771#comment-15988771
]
Vikas Saurabh commented on OAK-5893:
------------------------------------
Patch looks good to me. A few minor nit-picks though:
* Afaiu, traversal is being counted in {{childNodeAdded}} and
{{childNodeChanged}} - that potentially leaves a (minor) edge case out when
there are lots of updates in a large set of siblings. I wonder if we should
increment counter in propertyAdded/etc methods too.
* I'm not feeling so good about {{instanceof NodeTraversalCallback}} - could we
change the construction flow to have another parameter and ctor(s) with no
traversal callback param sets NOOP instance instead
> Async index abort should work even during traversals without index updates
> --------------------------------------------------------------------------
>
> Key: OAK-5893
> URL: https://issues.apache.org/jira/browse/OAK-5893
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: indexing
> Reporter: Vikas Saurabh
> Assignee: Chetan Mehrotra
> Priority: Minor
> Fix For: 1.8
>
> Attachments: OAK-5893-v1.patch
>
>
> With OAK-4262, we introduces a way to abort async index update. Currently,
> the check to abort is done when an index indeed gets updated. It would be
> useful to have abort check being done during traversal too (useful when
> reindexing is happening and traversal is on a tree which is not contributing
> to any index udpate)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
