[
https://issues.apache.org/jira/browse/OAK-6141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992515#comment-15992515
]
Alex Parvulescu commented on OAK-6141:
--------------------------------------
bq. the method mentioned is only used for migration from Jackrabbit 2.x to Oak.
ah, thanks for clarifying. I read the javadoc 'migration' as also 'upgrade'
(Oak -> Oak) and possibly 'sidegrade' (see new Oak Segment Tar format).
bq. would suggest to resolve this not a bug.
makes perfect sense
bq. what we could do though is moving the migration code (i.e. that very
method) to the oak-upgrade module as it is really not used elsewhere.
hmm, maybe move it to a local {{upgrade}} package?
> MembershipWriter setMembers() doesn't properly cleanup tree
> -----------------------------------------------------------
>
> Key: OAK-6141
> URL: https://issues.apache.org/jira/browse/OAK-6141
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, security
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
>
> I'm pretty sure this [0] is supposed to be instead:
> {noformat}
> group.getChildNode(UserConstants.REP_MEMBERS_LIST).remove();
> {noformat}
> in its current shape, this will fail to cleanup preexisting members.
> Also, I'd prefer if this would actually: 1. cleanup, 2. call existing
> #addMembers method to reduce code duplication.
> [~anchela] thoughts?
> [0]
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/MembershipWriter.java#L248
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
