[
https://issues.apache.org/jira/browse/OAK-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000454#comment-16000454
]
angela commented on OAK-6177:
-----------------------------
[~alex.parvulescu], i would suggest to cover that with a separate benchmark...
as far as i remember adding an existing member used to be almost as expensive
as adding a new one... so, i would like to keep that as part of the benchmarks
to make sure we would be able to catch any regression in that area. Adding a
new "AddUniqueMembersTest" that extends from "AddMembersTest" and just provides
different 'ids' should be doable with moderate effort, shouldn't it? Also we
can compare figures between the 2 as we go ahead.
> AddMembersTest should add unique items to groups
> ------------------------------------------------
>
> Key: OAK-6177
> URL: https://issues.apache.org/jira/browse/OAK-6177
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: benchmarks
> Reporter: Alex Parvulescu
> Assignee: Alex Parvulescu
> Priority: Minor
> Attachments: OAK-6177.patch
>
>
> In the current setup the {{AddMembersTest}} benchmark exhausts unique user
> ids and quite quickly starts adding existing items to the same groups
> reducing the usefulness of the profiling results (the Group code bails early
> for existing members).
> I think we should make this benchmark add only unique items. [~anchela] what
> do you think?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
