[
https://issues.apache.org/jira/browse/OAK-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038796#comment-16038796
]
angela commented on OAK-6297:
-----------------------------
[~tmueller], one reason is dependency of of {{oak.spi.query.Filter}} on
{{oak.query.fulltext.*}} classes as this mandates that the classes in fulltext
are as visible/exported as the {{Filter}} in the spi, which is again tied to
the spi package by the {{QueryIndex}} interface. as i was looking for means to
address OAK-6304 i felt that would be desirable to minimize the exposed classes
in {{query.fulltext}}. therefore, moving a workaround classes like
{{SimpleExcerptProvider}} out of that package, when it can be held package
private in {{oak.query}} seems better to me.
> SimpleExcerptProvider may be package private and moved to o.a.j.oak.query
> -------------------------------------------------------------------------
>
> Key: OAK-6297
> URL: https://issues.apache.org/jira/browse/OAK-6297
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, query
> Reporter: angela
> Priority: Minor
> Attachments: OAK-6297.patch
>
>
> the utility {{o.a.j.oak.fulltext.SimpleExcerptProvider}} has a single usage
> inside the {{o.a.j.oak.query}} package space {{ResultRowImpl}}. therefore i
> would suggest to move it to {{o.a.j.oak.query}} and mark it package private.
> [~tmueller], i would appreciate if you could review the patch for this move.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
