[ 
https://issues.apache.org/jira/browse/OAK-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057185#comment-16057185
 ] 

Tomek Rękawek commented on OAK-6376:
------------------------------------

Fixed for trunk in [r1799402|https://svn.apache.org/r1799402].

> Race condition in the CompositeNodeStore#merge
> ----------------------------------------------
>
>                 Key: OAK-6376
>                 URL: https://issues.apache.org/jira/browse/OAK-6376
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: composite
>            Reporter: Tomek Rękawek
>            Assignee: Tomek Rękawek
>             Fix For: 1.8, 1.7.4
>
>
> Following line in the CompositeNodeStore#merge() is prone for race condition:
> {code}
> NodeState processed = commitHook.processCommit(getRoot(), 
> rebase(nodeBuilder), info);
> {code}
> We should compare the rebase() results with the getRoot() method, but with 
> the nodeBuilder.getBaseState(). Otherwise, any changes in the root between 
> getRoot() and rebase() invocations will lead to processing external changes 
> in the commit hook.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to