[
https://issues.apache.org/jira/browse/OAK-6388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066404#comment-16066404
]
Thomas Mueller edited comment on OAK-6388 at 6/28/17 12:22 PM:
---------------------------------------------------------------
The patch looks good in general except for:
The license header is missing in the new file
oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/UtilsTest.java
and this:
{noformat}
+ if (!props.containsKey(AzureConstants.AZURE_SAS) ||
!props.containsKey(AzureConstants.AZURE_BLOB_ENDPOINT)
+ ||
!(props.containsKey(AzureConstants.AZURE_BLOB_CONTAINER_NAME)))
{noformat}
Here, "\{" is missing (and "\}" is missing after the return statement).
Basically, it shouldn't look like this:
{noformat}
if (condition1) {
if (condition2)
return false;
}
{noformat}
Instead, it should look like this:
{noformat}
if (condition1) {
if (condition2) {
return false;
}
}
{noformat}
was (Author: tmueller):
The patch looks good in general except for:
The license header is missing in the new file
oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/UtilsTest.java
and this:
{noformat}
+ if (!props.containsKey(AzureConstants.AZURE_SAS) ||
!props.containsKey(AzureConstants.AZURE_BLOB_ENDPOINT)
+ ||
!(props.containsKey(AzureConstants.AZURE_BLOB_CONTAINER_NAME)))
{noformat}
Here, "{" is missing (and "}" is missing after the return statement).
Basically, it shouldn't look like this:
{noformat}
if (condition1) {
if (condition2)
return false;
}
{noformat}
Instead, it should look like this:
{noformat}
if (condition1) {
if (condition2) {
return false;
}
}
{noformat}
> Enable Azure shared access signature for blob store connector
> -------------------------------------------------------------
>
> Key: OAK-6388
> URL: https://issues.apache.org/jira/browse/OAK-6388
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob-cloud
> Reporter: Andrei Kalfas
> Attachments: AzureSAS.patch
>
>
> Azure storage account can be access with access keys or with shared access
> signatures. Currently the blob connector only allows access keys, limiting
> the use cases where the storage account must be regarded as a read only one.
> Access keys enable all access while shared access signatures can be limited
> to certain operations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
