[
https://issues.apache.org/jira/browse/OAK-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081853#comment-16081853
]
Alex Deparvu edited comment on OAK-6440 at 7/11/17 8:26 AM:
------------------------------------------------------------
I was trying to understand the first version patch, but I was struggling a bit.
Second version makes more sense and seems less intrusive. If I read your last
comment correctly, this might be triggered by the fact that {{nt:base}} could
or not be present on the definition and this confuses the diff mechanism.
I say it looks good even though I don't fully understand the implications :)
ps. I'm wondering if patching the
{{NamedTemplate#getOakNamesOrThrowConstraintViolation}} to inject nt:base if it
doesn't exist has the same end result (no major changes detected) while at the
same time fixing the definitions.
[edit] attached a demo patch to explain my idea. feel free to ignore if it
doesn't look proper :)
was (Author: alex.parvulescu):
I was trying to understand the first version patch, but I was struggling a bit.
Second version makes more sense and seems less intrusive. If I read your last
comment correctly, this might be triggered by the fact that {{nt:base}} could
or not be present on the definition and this confuses the diff mechanism.
I say it looks good even though I don't fully understand the implications :)
ps. I'm wondering if patching the
{{NamedTemplate#getOakNamesOrThrowConstraintViolation}} to inject nt:base if it
doesn't exist has the same end result (no major changes detected) while at the
same time fixing the definitions.
> Incorrect node type diff
> ------------------------
>
> Key: OAK-6440
> URL: https://issues.apache.org/jira/browse/OAK-6440
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Affects Versions: 1.6.0
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 1.8
>
> Attachments: OAK-6440-1.patch, OAK-6440-fix-input.patch,
> OAK-6440.patch
>
>
> The type editor in Oak checks if a change to a node type requires a
> repository traversal to verify the existing content conforms to the new type.
> In some cases the current implementation detects a major change in type
> changes even though it is only minor.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
