[ 
https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089320#comment-16089320
 ] 

Chetan Mehrotra edited comment on OAK-6450 at 7/17/17 5:11 AM:
---------------------------------------------------------------

bq. Use the comoponent.name component property if the service.pid is not 
available. The SecurityProviderRegistration property name is unchanged, for 
backwards compatibility reasons.

Not sure if component.name can be relied upon as its specific to DS. Service 
can be registered without DS and hence may not have comoponent.name property 
defined. See [this 
comment|https://issues.apache.org/jira/browse/SLING-6578?focusedCommentId=15889812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15889812]
 and also the same bug for some discussion. 

Hence I recommended to go for some logical service property name like 
oak.security.name. 


was (Author: chetanm):
bq. Use the comoponent.name component property if the service.pid is not 
available. The SecurityProviderRegistration property name is unchanged, for 
backwards compatibility reasons.

Not sure if component.name would be stable and can be relied upon. See [this 
comment|https://issues.apache.org/jira/browse/SLING-6578?focusedCommentId=15889812&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15889812]
 and also the same bug for some discussion. 

Hence I recommended to go for some logical service property name like 
oak.security.name. 

> Stop relying on the service.pid property in SecurityProviderRegistration
> ------------------------------------------------------------------------
>
>                 Key: OAK-6450
>                 URL: https://issues.apache.org/jira/browse/OAK-6450
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>             Fix For: 1.8, 1.7.4
>
>         Attachments: 
> 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch
>
>
> As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi 
> property for tracking required services as it was incorrectly set so far by 
> the {{maven-scr-plugin}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to