[ 
https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated OAK-6450:
---------------------------------
    Attachment: 0002-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch

[~chetanm] - I've uploaded a second patch ( cumulates with the first ) which 
uses the {{oak.security.name}} component property instead of {{component.name}}.

I slight prefer the first variant as 
- I don't have to duplicate the class names everywhere
- components registered outside of SCR can set the {{component.name}} property 
themselves

All in all it's not a big deal, if the second variant looks better to you I 
will commit it.

> Stop relying on the service.pid property in SecurityProviderRegistration
> ------------------------------------------------------------------------
>
>                 Key: OAK-6450
>                 URL: https://issues.apache.org/jira/browse/OAK-6450
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: security
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>             Fix For: 1.8, 1.7.4
>
>         Attachments: 
> 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch, 
> 0002-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch
>
>
> As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi 
> property for tracking required services as it was incorrectly set so far by 
> the {{maven-scr-plugin}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to