[
https://issues.apache.org/jira/browse/OAK-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated OAK-5740:
-----------------------------
Attachment: OAK-5740.v3.patch
Attached [^OAK-5740.v3.patch] which combines [~catholicon]'s v2-patch.patch
ontop of v2.patch.
Reiterating the main change this would introduce:
* prior behavior was that the {{full}} boolean carried the overflow flag. Upon
arrival of a new commit and this flag being true and the queue was not empty,
an overflow entry would be added to the queue. Without any new commit arriving
though, this overflow entry (in the form of the {{full}} flag) would just sit
and wait (for a new commit).
* new behavior is that the {{full}} flag is gone. when a commit doesn't fit
into the queue, the last entry is removed and a compaction entry is added. if
more new commits arrive this procedure is repeated. This is a slight slower
implementation as it has to check-for-full, then remove, then add, while as
previously it was just doing a check-for-full. But this is when the queue is
full, so shouldnt influence normal behavior, and it is a rather academic aspect
anyway.
[~catholicon], [~mduerig], [~chetanm], [~mreutegg], wdyt, should I push the
patch?
> deliver overflow change even without new commit
> -----------------------------------------------
>
> Key: OAK-5740
> URL: https://issues.apache.org/jira/browse/OAK-5740
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Affects Versions: 1.6.0
> Reporter: Stefan Egli
> Assignee: Stefan Egli
> Priority: Minor
> Fix For: 1.8
>
> Attachments: OAK-5740.StuffAtop-v2-patch.patch,
> OAK-5740.testcase.patch, OAK-5740.testcase.patch, OAK-5740.v2.patch,
> OAK-5740.v3.patch
>
>
> As [reported|http://markmail.org/message/2qxle24f6zu2vpms] by [~catholicon]
> on oak-dev the observation queue only delivers the so-called _overflow
> entry/change_ only when new commits are 'coming in'. We might want to
> consider fixing this, even though arguably this is a very rare case (since
> typically the observation queue is configured to be very large)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
