[ 
https://issues.apache.org/jira/browse/OAK-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094514#comment-16094514
 ] 

Thomas Mueller commented on OAK-6407:
-------------------------------------

> see the various issues I fixed recently within the query code base to fix the 
> cyclic package dependencies.

I know about those issues, I just didn't know they where cyclic in some way... 
In my view, they were just "wrong" :-)

> that's the ultimate goal

If the goal is that oak-lucene doesn't depend on oak-core, then that's fine.

One question you didn't answer: Why do oak-jcr, oak-run, oak-authorization-cug, 
oak-store-composite,... need a direct dependency? Should this not be indirectly?

>  Refactor oak.spi.query into a separate module/bundle 
> ------------------------------------------------------
>
>                 Key: OAK-6407
>                 URL: https://issues.apache.org/jira/browse/OAK-6407
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, indexing, query
>            Reporter: angela
>            Assignee: angela
>              Labels: modularization
>             Fix For: 1.8
>
>         Attachments: OAK-6407.patch
>
>
> now that OAK-6304 and OAK-6355 have been resolved, i would like to suggest 
> that we move the _o.a.j.oak.spi.query_ code base into a separate 
> module/bundle in order to prevent the introduction of bogus cycles and odd 
> package exports in the future.
> [~tmueller], patch will follow asap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to