[ 
https://issues.apache.org/jira/browse/OAK-6507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116210#comment-16116210
 ] 

Michael Dürig edited comment on OAK-6507 at 8/7/17 8:13 AM:
------------------------------------------------------------

Implementing of above approach: 
https://github.com/mduerig/jackrabbit-oak/commit/909487ac9eec51e4193859e30fc84b51d09de7d4

The implementation uses the same slot in the segment header for the gc 
generation that was used in Oak 1.6. As the value recorded there is incremented 
on every gc invocation its semantic actually remains the same (should be an 
advantage for rolling upgrades). All additional logic is based on the 
information recorded in the new field at offset 4.

[~frm], could you please have a look?


was (Author: mduerig):
Will soon share a branch implementing above approach.

> Cleanup incorrectly removes base state created by full compaction
> -----------------------------------------------------------------
>
>                 Key: OAK-6507
>                 URL: https://issues.apache.org/jira/browse/OAK-6507
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Michael Dürig
>             Fix For: 1.8, 1.7.6
>
>
> The predicate used to mark segments for cleanup marks segments written by 
> full compactions. These segments are needed to reconstruct the full state of 
> the repository, together with the state built by tail compactions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to