[ 
https://issues.apache.org/jira/browse/OAK-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164539#comment-16164539
 ] 

Marcel Reutegger commented on OAK-5656:
---------------------------------------

This is only required for OSGi deployments and there are alternatives:

- A bundle that wants to use this initializer could also inline the class at 
build time. This avoids the need to export the package.
- We move the initializer to a separate package to minimize the exported 
surface. At the moment none of the DocumentMK related packages are exported.

I don't have a strong preference... What do you prefer?

> InitialContent depends on document.bundlor.BundlingConfigInitializer
> --------------------------------------------------------------------
>
>                 Key: OAK-5656
>                 URL: https://issues.apache.org/jira/browse/OAK-5656
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: angela
>            Assignee: Marcel Reutegger
>            Priority: Minor
>              Labels: modularization, tech-debt
>             Fix For: 1.8
>
>         Attachments: OAK-5656.patch, OAK-5656.patch
>
>
> [~chetanm], in the light of OAK-4975 a dependency to the document nodestore 
> code got introduced in 
> {{org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent}} by adding 
> the following line:
> {code}
>         BundlingConfigInitializer.INSTANCE.initialize(builder);
> {code}
> the {{BundlingConfigInitializer}} is defined in the 
> {{org.apache.jackrabbit.oak.plugins.document.bundlor}}.
> To me that looks quite troublesome and I don't think the generic 
> JCR-InitialContent should have any dependency on the document nodestore code 
> base.
> Why not defining a dedicated {{RepositoryInitializer}} for that kind of init 
> an making sure it is listed in the (default) setup scenarios (or at least in 
> those that actually have a document store and thus require this)?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to