[
https://issues.apache.org/jira/browse/OAK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164811#comment-16164811
]
angela commented on OAK-6221:
-----------------------------
[~stillalex], uh.... that patch is huge :-) i like the general direction a
lot... just having a quick look, i was wondering, why the methods like e.g.
{{CompositeRestrictionProvider.newInstance(@Nonnull RestrictionProvider...
providers}} got deprecated.... this introduced a lot of {{ImmutableSet.of}}
being added to the tests calling those.
regarding the questions:
- as you state the issue with {{AuthorizationConfigurationImpl}} and
{{CugConfiguration}} is almost identical. regarding {{mountInfoProvider}}
rather being optional: i think you are better suited to answer that question
:-) i don't have a strong preference.
- regarding {{ExternalPrincipalConfiguration}}: yes, that doesn't work outside
of OSGi as does the rest of the external-authentication code... therefore I
decided to just do it for the OSGi setup. if you see a compelling reason why
this needs to be available in non-OSGi setup, let me know such that i can fix
it for you. otherwise i would just leave it as it is.
> Deprecate SecurityProviderImpl
> ------------------------------
>
> Key: OAK-6221
> URL: https://issues.apache.org/jira/browse/OAK-6221
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security
> Reporter: Alex Deparvu
> Assignee: Alex Deparvu
>
> As agreed on OAK-6172, the {{SecurityProviderImpl}} should be deprecated in
> favor of the {{InternalSecurityProvider}}.
> This should also cover coming up with a way to use the new version in tests
> while we figure out OSGi testing setups.
> fyi [~anchela]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
