[
https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173444#comment-16173444
]
angela commented on OAK-6662:
-----------------------------
[~stillalex], patch looks good to me in general... minor comments:
- i think we need more tests reflecting the behavior when multiple impls are
present
- i am not totally sure if the composite shouldn't have the
{{SimpleCredentialsSupport}} included as well for compatibility reasons...
let's assume someone has 2 JAAS entries for {{ExternalLoginModule}} configured
with 2 different external-IDPs; the first one is the {{LDAPIdentityProvider}},
which doesn't implement {{CredentialsSupport}} and thus falls back to the
{{SimpleCredentialsSupport}}, the second one implements it... wouldn't that
lead to the situation where the {{TokenProviderImpl}} would no longer properly
work for the LDAP-login-sync setup?... let's have a test for that scenario to
see I am missing something.
> Extend CredentialsSupport pluggability
> --------------------------------------
>
> Key: OAK-6662
> URL: https://issues.apache.org/jira/browse/OAK-6662
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Antonio Sanso
>
> At the moment the {{TokenConfigurationImpl}} binds a
> {{ReferenceCardinality.OPTIONAL_UNARY}} for {{CredentialsSupport}}.
> It would be useful to extend the support to {{OPTIONAL_MULTIPLE}} in order to
> cover more generic cases.
> cc [~anchela]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
