[
https://issues.apache.org/jira/browse/OAK-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194229#comment-16194229
]
angela commented on OAK-6318:
-----------------------------
[~rombert], thanks for your input. regarding:
{quote}
but maybe copy the affected classes to a new package and a new bundle would
solve the issue
{quote}
That's what we did with the various subtasks in OAK-6319. However, the main
issue doesn't get addressed by that. Which is: we cannot move the entire
_o.a.j.oak.plugins.tree_ package including the deprecated factories to
_oak-security-spi_ without introducing cyclic dependencies to _oak-core_... and
we tried more than once. We felt that we only had 2 options left:
- splitting the _o.a.j.oak.plugins.tree_ package across different bundles (i.e.
keeping the factories in oak-core while moving the rest to oak-security-spi as
[~stillalex] did... that worked for us locally but caused failures on some
platforms.
- major version bump by entirely dropping the factories from
_o.a.j.oak.plugins.tree_ (we already have the replacement and refactored all
usages in oak, see OAK-6319)... so basically that is what is left at this point.
If there is a option we missed to evaluate so far... even better.
> Refactor oak.spi.security into a separate module/bundle
> -------------------------------------------------------
>
> Key: OAK-6318
> URL: https://issues.apache.org/jira/browse/OAK-6318
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: core, security
> Reporter: angela
> Assignee: angela
> Attachments: PropInfo.patch
>
>
> In the light of the modularization effort it would IMHO make a lot of sense
> to refactor _oak.spi.security.*_ into a separate module/bundle that could be
> release independent of _oak-core_.
> As far as I could see so far this is currently not easily doable due to the
> dependency of {{oak.spi.security.*}} on {{oak.plugins.tree}}, which in turn
> relies on {{o.a.j.oak.query.QueryEngineSettings}} and other oak-core
> internals (see also OAK-6304). Most likely this issue would therefore require
> a complete review (and possibly a split) of the {{oak.plugins.tree}} package
> space which contains a mixture of utilities and 'API' (like e.g.
> {{TreeContext}} and {{TreeLocation}})... will open a separate issue for this
> linking to this one.
> cc: [~stillalex], [~rombert], [~mduerig], [~tmueller]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
