[ 
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194264#comment-16194264
 ] 

Julian Sedding commented on OAK-6741:
-------------------------------------

bq. Julian Sedding you might want to check your facts before pointing the 
finger. we already have a test for this [0]. why this test is not failing with 
the changed annotation, is a different question (it's probably the test 
framework that does not respect the wiring, but I'm no OSGi expert).

With all due respect [~stillalex], I think your quoting me out of context. As 
for the facts, you say yourself that the test does not fail. So we don't have a 
test that covers the scenario imlemented in OAK-6753. This is evident by the 
fact that the test was not adjusted when OAK-6753 was implemented.

Anyway, we're splitting hairs. If you would like me to revert the patch, please 
tell me so.

> Switch to official OSGi component and metatype annotations
> ----------------------------------------------------------
>
>                 Key: OAK-6741
>                 URL: https://issues.apache.org/jira/browse/OAK-6741
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Robert Munteanu
>             Fix For: 1.8, 1.7.9
>
>         Attachments: osgi-metadata-1.7.8.json, osgi-metadata-trunk.json
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi 
> R6 annotations.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to