[ 
https://issues.apache.org/jira/browse/OAK-6790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198260#comment-16198260
 ] 

Chetan Mehrotra commented on OAK-6790:
--------------------------------------

bq. Otoh, not picking up oak-query-spi on such setup would still fail to 
resolve the bundle.

That would. But here case would be that Oak user updated to newer version of 
Oak based application which adds all the new bundles. However his bundle would 
still not resolve even with oak-uery-spi being present

bq. All that said, I think we have moved around quite a few packages in the 
refactoring exercise. So, if we're ok with a bit of backward incompatibility 
hit, I think the current place (bundle and package) is more fitting place.

Most of such moves involved packages which were to be consumed by other Oak 
bundles hence changing them does not impact backward compatability. However 
this package was meant to be consumer by non Oak bundles and hence would pose 
problem

> FacetResult class isn't exposed anymore
> ---------------------------------------
>
>                 Key: OAK-6790
>                 URL: https://issues.apache.org/jira/browse/OAK-6790
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>    Affects Versions: 1.7.2
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>             Fix For: 1.8, 1.7.10
>
>
> OAK-3847 exposed {{FacetResult}} (rather 
> {{org.apache.jackrabbit.oak.query.facet}} package) to easily consume 
> extracted facet data. That exported package got removed during OAK-6304 (as 
> noted in this comment \[1]).
> We need to export that class - maybe that class makes sense as part of 
> {{oak-query-spi}} module - that still needs to be checked as assessed btw (ie 
> if we can simply re-enable the removed export AND that its current place in 
> oak-core still makes sense or not).
> [~anchela], would you remember what was the warning that was observed without 
> removing this export (disclaimer: I still feel that it belongs in 
> {{oak-query-spi}}... I'm just trying to have all data available).
> \[1]: 
> https://issues.apache.org/jira/browse/OAK-6304?focusedCommentId=16042721&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16042721



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to