[
https://issues.apache.org/jira/browse/OAK-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulceanu updated OAK-6615:
---------------------------------
Attachment: OAK-6615-02.patch
bq. Could we move {{SegmentTarFixture.SegmentTarFixtureBuilder}} to
{{OakFixture}} and expose it from there through a static method instead of the
various (and confusing) overloads of {{OakFixture#getSegmentTar}}?
I chose not to move the {{SegmentTarFixtureBuilder}} to {{OakFixture}} since I
thought it's just internal stuff pertaining to {{SegmentTarFixture}}. Instead,
I chose to clean up the confusing overloads of {{OakFixture#getSegmentTar}} by
introducing three new methods with clearer names: {{#getVanillaSegmentTar}} for
{{OAK_SEGMENT_TAR}}, {{#getSegmentTarWithDataStore}} for {{OAK_SEGMENT_TAR_DS}}
and {{#getSegmentTarWithColdStandby}} for {{OAK_SEGMENT_TAR_COLD}}.
bq. {{SegmentTarFixture#setUpCluster}} is confusingly long and nested. Would be
great to simplify that method.
Agreed. I tried to simplify {{SegmentTarFixture#setUpCluster}} by moving parts
related to cluster initialisation and standby instance(s) creation to dedicated
methods (i.e. {{SegmentTarFixture#init}} and
{{SegmentTarFixture#attachStandby}}. I also added meaningful JavaDoc to better
explain their purpose.
[~mduerig], WDYT? Could you review the latest patch, please?
> Add new segment-tar fixture for attaching a cold-standby to benchmarked
> primary
> -------------------------------------------------------------------------------
>
> Key: OAK-6615
> URL: https://issues.apache.org/jira/browse/OAK-6615
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: benchmarks, segment-tar
> Reporter: Andrei Dulceanu
> Assignee: Andrei Dulceanu
> Priority: Minor
> Labels: cold-standby
> Fix For: 1.8, 1.7.10
>
> Attachments: OAK-6615-02.patch, OAK-6615.patch
>
>
> If this fixture is chosen, a cold standby instance will be started, syncing
> with the primary every {{n}} seconds. All the benchmarks specified via
> {{[testcases]}} argument will be run on primary instance, and all statistics
> and reports will be linked to primary.
> This could work similarly to {{Oak-Segment-Tar-DS}} and have dedicated
> options like {{--no-data-store}}, {{--private-data-store}} or
> {{--shared-data-store}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
