[
https://issues.apache.org/jira/browse/OAK-6807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218791#comment-16218791
]
Chetan Mehrotra commented on OAK-6807:
--------------------------------------
Looks fine. Few comments
* Not sure how many concurrent query calls happen - If required we can use
ConcurrentHashMap with putIfAbsent and only handle the overflow case in
synchronized mode
* Log stats on shutdown to capture low usage mode
* Log line to have simple format for easier parsing
{noformat}
LOG.debug("|{}|{}", query, count);
{noformat}
* -Later a JMX view over the same would be useful- Leave that I would later add
a status printer for this so that it can get included in config status dump
(like support for index definitions)
[~catholicon] You have any wish list here!
> Query Recorder
> --------------
>
> Key: OAK-6807
> URL: https://issues.apache.org/jira/browse/OAK-6807
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Fix For: 1.8
>
>
> In order to manage indexes (e.g. find out which indexes are no longer needed,
> which properties don't need to be indexed any longer), we have an easy way to
> log all executed queries / query plans.
> Each entry only needs to be logged once (logging multiple times is OK, but
> ensure it's not logged to often). Different log levels can be used (e.g. log
> level "TRACE" logs more data, "DEBUG" less). For "DEBUG" level, overhead of
> logging should be minimal, so this can be kept enabled for a long time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
