[
https://issues.apache.org/jira/browse/OAK-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220526#comment-16220526
]
Francesco Mari commented on OAK-6829:
-------------------------------------
I forced timeouts in {{NetworkErrorProxy}} and {{ForwardHandler}} to throw
exceptions instead of logging a debug message and go on (r1813405). This should
help detecting timeouts early on instead of trying to continue on a potentially
buggy test setup.
I also let {{ForwardHandler}} react to channel activation and deactivation
instead of to registration and deregistration (r1813406). The difference
between the two kind of events is important. By listening to
activation/deactivation, {{ForwardHandler}} reacts to the state of the channel.
For example, if the standby closes its connection to the proxy,
{{ForwardHandler}} will close its corresponding connection to the primary. If a
deregistration event is used instead, {{ForwardHandler}} disconnects from the
primary only when it is removed from the pipeline. This happens only when the
proxy is closed, but not when the proxy is reset. The consequence is that a
connection is leaked between the primary and the proxy, even if the other end
of the proxy (the one that should be connected to the standby) might be closed.
> ExternalPrivateStoreIT/ExternalSharedStoreIT.testSyncBigBlob failures
> ---------------------------------------------------------------------
>
> Key: OAK-6829
> URL: https://issues.apache.org/jira/browse/OAK-6829
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
> Affects Versions: 1.7.9
> Reporter: Julian Reschke
> Assignee: Francesco Mari
> Fix For: 1.8, 1.7.11
>
> Attachments:
> TEST-org.apache.jackrabbit.oak.segment.standby.ExternalPrivateStoreIT.xml,
> TEST-org.apache.jackrabbit.oak.segment.standby.ExternalSharedStoreIT.xml,
> org.apache.jackrabbit.oak.segment.standby.ExternalPrivateStoreIT-output.txt,
> org.apache.jackrabbit.oak.segment.standby.ExternalSharedStoreIT-output.txt
>
>
> {noformat}
> testSyncBigBlob(org.apache.jackrabbit.oak.segment.standby.ExternalPrivateStoreIT)
> Time elapsed: 27.921 sec <<< FAILURE!
> java.lang.AssertionError: expected:<{ root = { ... } }> but was:<{ root : { }
> }>
> Running org.apache.jackrabbit.oak.segment.standby.ExternalSharedStoreIT
> Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 93.353 sec
> <<< FAILURE! - in
> org.apache.jackrabbit.oak.segment.standby.ExternalSharedStoreIT
> testSyncBigBlob(org.apache.jackrabbit.oak.segment.standby.ExternalSharedStoreIT)
> Time elapsed: 30.772 sec <<< FAILURE!
> java.lang.AssertionError: expected:<{ root = { ... } }> but was:<{ root : { }
> }>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
