[ 
https://issues.apache.org/jira/browse/OAK-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222157#comment-16222157
 ] 

Tomek Rękawek edited comment on OAK-6878 at 10/27/17 10:51 AM:
---------------------------------------------------------------

[~amjain] - looking at it now, it seems that in this case the Properties are 
not typed - all the values are strings. It's caused by the for() loop in the 
constructor, which strips the OSGi type prefixes (B"true" \-> true; 
I"123"\->123), so the OSGi configuration can be used as well as the normal 
properties file.

So, we need to get rid of this logic or apply it only when needed (eg. 
depending on the extension).


was (Author: tomek.rekawek):
[~amjain] - looking at it now, it seems that in this case the Properties are 
not typed - all the values are strings. It's caused by the for() loop in the 
constructor, which strips the OSGi type prefixes (B"true" -> true; 
I"123"->123), so the OSGi configuration can be used as well as the normal 
properties file.

So, we need to get rid of this logic or apply it only when needed (eg. 
depending on the extension).

> Populate S3DataStore fields with the passed properties in oak-upgrade
> ---------------------------------------------------------------------
>
>                 Key: OAK-6878
>                 URL: https://issues.apache.org/jira/browse/OAK-6878
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: upgrade
>            Reporter: Tomek Rękawek
>             Fix For: 1.8
>
>         Attachments: OAK-6878.patch, OAK_6878_2.patch
>
>
> The S3DataStore class inherits many fields which can be used for the 
> configuration (eg. cacheSize). In order to set these fields with values read 
> from the properties file we should use {{PropertiesUtil.populate()}} method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to