[ 
https://issues.apache.org/jira/browse/OAK-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Mari updated OAK-6915:
--------------------------------
    Attachment: OAK-6915-01.patch

The first version of the fix is a partial rewrite of the {{SegmentCache}} to 
make better use of the underlying Guava cache. The patch also contains a minor 
fix for a unit test and some additional readjustments of related classes.

With this patch and the diagnostics patch in place, I run {{StandbyTestIT}} 
once more. While the amount of allocations of new {{SegmentId}} remains 
unchanged, the number of uncached segment reads is down to about 260.

There is still some work to do. With the patch in place a couple of integration 
tests don't pass. Nevertheless, the preliminary data shows that the additional 
work might be worth the effort.

> Minimize the amount of uncached segment reads
> ---------------------------------------------
>
>                 Key: OAK-6915
>                 URL: https://issues.apache.org/jira/browse/OAK-6915
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>             Fix For: 1.8, 1.7.12
>
>         Attachments: OAK-6915-01.patch, OAK-6915-diagnostics.patch
>
>
> The current implementation of {{SegmentCache}} should make better use of the 
> underlying Guava cache by relying on the cached segments instead of 
> unconditionally performing an uncached segment read via the 
> {{Callable<Segment>}} passed to {{SegmentCache#getSegment}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to