[
https://issues.apache.org/jira/browse/OAK-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247585#comment-16247585
]
Andrei Dulceanu edited comment on OAK-6915 at 11/10/17 3:53 PM:
----------------------------------------------------------------
[~mduerig], LGTM. I find your explanation in {{SegmentCache#putSegment()}}
clear and detailed.
And here are the results when running {{BasicWriteTest}}:
{noformat}
# BasicWriteTest C min 10% 50% 90% max
N
Oak-Segment-Tar 1 19 21 23 29 271
2239
Oak-Segment-Tar-Cold 1 58 62 65 73 198
872
{noformat}
was (Author: dulceanu):
[~mduerig], LGTM. I find your explanation in {{SegmentCache#putSegment()}}
clear and detailed.
> Minimize the amount of uncached segment reads
> ---------------------------------------------
>
> Key: OAK-6915
> URL: https://issues.apache.org/jira/browse/OAK-6915
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Fix For: 1.8, 1.7.12
>
> Attachments: OAK-6915-01.patch, OAK-6915-02.patch, OAK-6915-03.patch,
> OAK-6915-04.patch, OAK-6915-05.patch, OAK-6915-diagnostics-02.patch,
> OAK-6915-diagnostics.patch, OAK-6915.patch, Screen Shot 2017-11-09 at
> 14.14.28.png, Screen Shot 2017-11-09 at 14.16.59.png
>
>
> The current implementation of {{SegmentCache}} should make better use of the
> underlying Guava cache by relying on the cached segments instead of
> unconditionally performing an uncached segment read via the
> {{Callable<Segment>}} passed to {{SegmentCache#getSegment}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
