[
https://issues.apache.org/jira/browse/OAK-6931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251095#comment-16251095
]
Francesco Mari commented on OAK-6931:
-------------------------------------
I would add a check in {{Compact.Builder#withSegmentCacheSize}} to enforce the
provided value to be greater than or equal to zero, or throw an
{{IllegalArgumentException}} otherwise. Moreover, I would add some Javadoc on
that method, too.
> Enable the -Dcache of offline compaction
> ----------------------------------------
>
> Key: OAK-6931
> URL: https://issues.apache.org/jira/browse/OAK-6931
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Affects Versions: 1.6.7
> Reporter: Michael Dürig
> Assignee: Michael Dürig
> Labels: compaction, gc, tooling
> Fix For: 1.8, 1.6.6, 1.7.12
>
> Attachments: OAK-6931.patch
>
>
> The {{-Dcache}} option currently has no effect when used in conjunction with
> the {{compact}} run mode of {{oak-run}}. However we should enable users to
> configure the segment cache size through this option if necessary.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
