[ 
https://issues.apache.org/jira/browse/OAK-6066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259113#comment-16259113
 ] 

Tomek Rękawek commented on OAK-6066:
------------------------------------

Fixed for trunk in [r1815789|https://svn.apache.org/r1815789].

> Migration of binaries relies on implementation details of the TarMK
> -------------------------------------------------------------------
>
>                 Key: OAK-6066
>                 URL: https://issues.apache.org/jira/browse/OAK-6066
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>            Reporter: Michael Dürig
>            Assignee: Tomek Rękawek
>              Labels: migration, tooling
>             Fix For: 1.8, 1.7.12
>
>         Attachments: OAK_6066.patch
>
>
> This was uncovered with the work on OAK-6051.
> On {{NodeStore.merge()}} the TarMK uses {{SegmentNodeState#fastEquals}} to 
> efficiently determine whether there is something to commit and whether the 
> base state changed since the builder about to commit was acquired. For 
> efficiency reasons {{fastEquals}} can return "false negatives". AFAIU 
> migration of binaries depends on this implementation detail because without 
> this optimisation migration fails. ({{SegmentToExternalMigrationTest}} and 
> {{ExternalToExternalMigrationTest}} fail). 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to