[ 
https://issues.apache.org/jira/browse/OAK-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266781#comment-16266781
 ] 

Davide Giannella commented on OAK-6945:
---------------------------------------

[~mreutegg]
bq. MicroBenchmark was introduced as a utility for the CompactionMapTest, which 
is not present anymore in segment-tar. I'd rather move the MicroBenchmark class 
under src/test if we still want to keep the class. It doesn't look like Oak 
would ever use it from a production class.

if it's not used any more I'm for removing it. 

bq. PerfLogger was moved into this package as part of OAK-6073, but is in my 
view unrelated to benchmarks. I'd rather move it to o.a.j.o.commons and then 
the benchmark package could be removed.

+1



> Add package export versions for oak-commons
> -------------------------------------------
>
>                 Key: OAK-6945
>                 URL: https://issues.apache.org/jira/browse/OAK-6945
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: commons
>            Reporter: angela
>            Assignee: Marcel Reutegger
>             Fix For: 1.8, 1.7.12
>
>
> Same as OAK-6942 for the _oak-commons_ package: we export everything therein 
> and disabled the baseline plugin for everything.
> in order to be able to properly manage the API contracts of those public 
> APIs, I would suggest we add the package-info.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to