[
https://issues.apache.org/jira/browse/OAK-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280026#comment-16280026
]
Vikas Saurabh edited comment on OAK-7007 at 12/6/17 11:10 AM:
--------------------------------------------------------------
Indeed, I also discovered the same fact a few minutes ago. I could reproduce it
locally by forcing ResultSizeTest run before FacetTest with following patch and
maven command:
{noformat}
$ git status
On branch 1.4
Your branch is up-to-date with 'fork-origin/1.4'.
Changes to be committed:
(use "git reset HEAD <file>..." to unstage)
renamed:
oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/FacetTest.java ->
oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
modified: oak-parent/pom.xml
$ git diff
diff --git
a/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
b/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
index 24b13eb93..19835dc26 100644
---
a/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
+++
b/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
@@ -36,7 +36,7 @@ import org.junit.Before;
/**
* Test for faceting capabilities via JCR API
*/
-public class FacetTest extends AbstractQueryTest {
+public class SFacetTest extends AbstractQueryTest {
public static final String FACET_CONFING_PROP_PATH =
"/oak:index/luceneGlobal/indexRules/nt:base/properties/allProps/facets";
public static final String FACET_CONFING_NODE_PATH =
"/oak:index/luceneGlobal/facets";
diff --git a/oak-parent/pom.xml b/oak-parent/pom.xml
index f40cd7a37..64160d092 100644
--- a/oak-parent/pom.xml
+++ b/oak-parent/pom.xml
@@ -74,6 +74,7 @@
<!-- whether skip the surefire unit testing during the integration testing.
Override with -Dsurefire.skip.ut=true when needed -->
<surefire.skip.ut>false</surefire.skip.ut>
+ <surefire.test.runOrder>filesystem</surefire.test.runOrder>
</properties>
<issueManagement>
@@ -288,6 +289,7 @@
<derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
</systemPropertyVariables>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <runOrder>${surefire.test.runOrder}</runOrder>
</configuration>
</plugin>
<plugin>
$ mvn verify -Dsurefire.test.runOrder=alphabetical
-Dtest=ResultSizeTest,SFacetTest -pl :oak-lucene
{noformat}
was (Author: catholicon):
Indeed, I also discovered the same fact a few minutes ago. I could reproduce it
locally by forcing ResultSizeTest run before FacetTest with following patch and
maven command:
{noformat}
$ git diff
diff --git
a/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
b/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
index 24b13eb93..19835dc26 100644
---
a/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
+++
b/oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/SFacetTest.java
@@ -36,7 +36,7 @@ import org.junit.Before;
/**
* Test for faceting capabilities via JCR API
*/
-public class FacetTest extends AbstractQueryTest {
+public class SFacetTest extends AbstractQueryTest {
public static final String FACET_CONFING_PROP_PATH =
"/oak:index/luceneGlobal/indexRules/nt:base/properties/allProps/facets";
public static final String FACET_CONFING_NODE_PATH =
"/oak:index/luceneGlobal/facets";
diff --git a/oak-parent/pom.xml b/oak-parent/pom.xml
index f40cd7a37..64160d092 100644
--- a/oak-parent/pom.xml
+++ b/oak-parent/pom.xml
@@ -74,6 +74,7 @@
<!-- whether skip the surefire unit testing during the integration testing.
Override with -Dsurefire.skip.ut=true when needed -->
<surefire.skip.ut>false</surefire.skip.ut>
+ <surefire.test.runOrder>filesystem</surefire.test.runOrder>
</properties>
<issueManagement>
@@ -288,6 +289,7 @@
<derby.stream.error.file>${project.build.directory}/derby.log</derby.stream.error.file>
</systemPropertyVariables>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <runOrder>${surefire.test.runOrder}</runOrder>
</configuration>
</plugin>
<plugin>
$ mvn verify -Dsurefire.test.runOrder=alphabetical
-Dtest=ResultSizeTest,SFacetTest -pl :oak-lucene
{noformat}
> Test failure: FacetTest.testFacetsNA()
> --------------------------------------
>
> Key: OAK-7007
> URL: https://issues.apache.org/jira/browse/OAK-7007
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
> Environment: OpenJDK 7
> Reporter: Marcel Reutegger
> Assignee: Vikas Saurabh
> Fix For: 1.4.19
>
>
> Builds on travis fail rather consistently on the 1.4 branch.
> Most recently https://travis-ci.org/apache/jackrabbit-oak/builds/305370560
> The failure is:
> {noformat}
> java.lang.RuntimeException: java.lang.RuntimeException:
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.query.facet.FacetResult.<init>(FacetResult.java:63)
> at
> org.apache.jackrabbit.oak.jcr.query.FacetTest.testFacetsNA(FacetTest.java:115)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at
> org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:464)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> at
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
> Caused by: java.lang.RuntimeException: java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LucenePathCursor$2.getValue(LucenePropertyIndex.java:1628)
> at
> org.apache.jackrabbit.oak.query.ast.SelectorImpl.currentOakProperty(SelectorImpl.java:679)
> at
> org.apache.jackrabbit.oak.query.ast.SelectorImpl.currentOakProperty(SelectorImpl.java:652)
> at
> org.apache.jackrabbit.oak.query.ast.SelectorImpl.currentOakProperty(SelectorImpl.java:584)
> at
> org.apache.jackrabbit.oak.query.ast.FacetColumnImpl.currentProperty(FacetColumnImpl.java:33)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.currentRow(QueryImpl.java:885)
> at
> org.apache.jackrabbit.oak.query.QueryImpl$RowIterator.fetchNext(QueryImpl.java:826)
> at
> org.apache.jackrabbit.oak.query.QueryImpl$RowIterator.hasNext(QueryImpl.java:849)
> at
> org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$1.fetch(QueryResultImpl.java:98)
> at
> org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$1.<init>(QueryResultImpl.java:94)
> at
> org.apache.jackrabbit.oak.jcr.query.QueryResultImpl.getRows(QueryResultImpl.java:78)
> at
> org.apache.jackrabbit.oak.query.facet.FacetResult.<init>(FacetResult.java:48)
> ... 27 more
> Caused by: java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.FilteredSortedSetDocValuesFacetCounts.getTopChildren(FilteredSortedSetDocValuesFacetCounts.java:63)
> at
> org.apache.lucene.facet.MultiFacets.getTopChildren(MultiFacets.java:52)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex$LucenePathCursor$2.getValue(LucenePropertyIndex.java:1614)
> ... 38 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
