[
https://issues.apache.org/jira/browse/OAK-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283494#comment-16283494
]
Thomas Mueller commented on OAK-5896:
-------------------------------------
I don't think it's possible (with the current logic) to write a simple test
case that fails with without the patch, and works with this patch. This is
because containsUnfilteredFullTextCondition will never returns true if
requiresFullTextIndex returns false. Currently, there are only 3 cases:
* requiresFullTextIndex and containsUnfilteredFullTextCondition both return
false
* requiresFullTextIndex returns true, and containsUnfilteredFullTextCondition
returns false
* requiresFullTextIndex and containsUnfilteredFullTextCondition both return true
So changing the logic to requiresFullTextIndex ||
containsUnfilteredFullTextCondition won't make a difference in practise.
But it also doesn't hurt, and maybe the logic changes in the future. So I will
apply the patch.
> fix typo in Not condition handling
> ----------------------------------
>
> Key: OAK-5896
> URL: https://issues.apache.org/jira/browse/OAK-5896
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
> Affects Versions: 1.6.1
> Reporter: Dave Brosius
> Assignee: Thomas Mueller
> Priority: Trivial
> Fix For: 1.7.13, 1.8
>
> Attachments: 5896.txt
>
>
> code stutters the same condition twice, looks like a typo. patch attached.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
