[
https://issues.apache.org/jira/browse/OAK-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289232#comment-16289232
]
Thomas Mueller commented on OAK-7052:
-------------------------------------
> there seem to be a LOT of inlined blobs
Yes, it would be good if this is resolved... Isn't there a method to check if a
blob id is inlined? I think SharedDataStore.resolveChunks could be used (if it
returns an empty set, it's inline). [~amit5094] is this the right way? If there
is no such method yet, it would be great to add one.
> should we tie it with blob store's inline threshold.... I don't feel that way
> though
No, that would be wrong (the threshold can be changed anytime, and if the
customer does that we are in trouble).
I think it would be better if the iterator is closed in a finally block as in
the example
https://github.com/apache/commons-io/blob/master/src/main/java/org/apache/commons/io/FileUtils.java#L1909
I see there is no good way to write a unit test to verify it doesn't run out of
memory... too bad, but not sure what could be done about that.
> Active deletion purge can OOM if number of blobs listed in a file become too
> large
> ----------------------------------------------------------------------------------
>
> Key: OAK-7052
> URL: https://issues.apache.org/jira/browse/OAK-7052
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
> Reporter: Vikas Saurabh
> Assignee: Vikas Saurabh
> Fix For: 1.8
>
>
> Actively deletion, while purging, reads blob ids from a file using
> {{FileUtils#readLines}}. That method returns a list, while we only require to
> iterate over the file contents line-by-line.
> We should probably switch to {{FileUtils#lineIterator}} to clearly declare
> our intent to read line by line.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)