[ 
https://issues.apache.org/jira/browse/OAK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294646#comment-16294646
 ] 

Dirk Rudolph commented on OAK-7070:
-----------------------------------

There is still the risk, that duplication appear in the excerpt because there 
is a highlighting hit in {{:fulltext}} and one for example in {{full:bar}}. To 
prevent that, it probably makes sense to first do the highlighting on 
{{:fulltext}} fields when analyzeFulltext is enabled and only if that hasn't 
been success full we fallback to the logic of highlighting {{full:}} fields. 
wdyt?

> rep:excerpt selector broken as regression of OAK-6750
> -----------------------------------------------------
>
>                 Key: OAK-7070
>                 URL: https://issues.apache.org/jira/browse/OAK-7070
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.6.7, 1.8
>            Reporter: Dirk Rudolph
>            Assignee: Vikas Saurabh
>              Labels: excerpt
>
> The change made here:
> https://github.com/apache/jackrabbit-oak/commit/00c94b71293abcae6d76bb162c3f55c7d09b702e#diff-d4bdf443c61f24b634f33aab607e2114
> breaks the logic in line 676:
> {{else if (oakPropertyName.equals(QueryConstants.REP_EXCERPT + "("))}}
> This statement doesn't make much sense considering a query like {{select 
> \[rep:excerpt] from \[test:Page] as page where contains(\*, 'term\*')}} or 
> even {{select \[rep:excerpt(text)] from \[test:Page] as page where 
> contains(page.\[text], 'term\*')}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to