[
https://issues.apache.org/jira/browse/OAK-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296560#comment-16296560
]
Dirk Rudolph edited comment on OAK-7070 at 12/19/17 9:55 AM:
-------------------------------------------------------------
Thanks [~catholicon] Your understanding is correct. And yes, I will move the
comment to OAK-6597.
To give a bit more context: I'm working currently on an AEM 6.3 project
implementing fulltext search and we recently upgraded to 1.6.7 to make use of
the changes in OAK-6750. Though our requirements also ask for excerpts and
that's why I investigated in OAK-6597 as well and asked there for a backport it
to 1.6. As this is blocking OAK-6597 and if we agree on making OAK-6597
available in 1.6 I would still like to backport it. The risk should be minimal
and afaik I applied those changes to my for of 1.6 without any problems. Don't
doing so opens the risk for us to use an unoffical port of oak for our project
- or rejecting some of the customers requirements. This also comes together
with OAK-7078 and OAK-7071.
was (Author: diru):
Thanks [~catholicon] Your understanding is correct. And yes, I will move the
comment to OAK-6597.
To give a bit more context: I'm working currently on an AEM 6.3 project
implementing fulltext search and we recently upgraded to 1.6.7 to make use of
the changes in OAK-6750. Though our requirements also ask for excerpts and
that's why I investigated in OAK-6597 as well and ask there for a backport to
1.6 too. As this is blocking OAK-6597 and if we agree on making OAK-6597
available in 1.6 I would still like to backport it. The risk should be minimal
and afaik I applied those changes to my for of 1.6 without any problems. Don't
doing so opens the risk for us to use an unoffical port of oak for our project
- or rejecting some of the customers requirements. This also comes together
with OAK-7078 and OAK-7071.
> rep:excerpt selector broken as regression of OAK-6750
> -----------------------------------------------------
>
> Key: OAK-7070
> URL: https://issues.apache.org/jira/browse/OAK-7070
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
> Affects Versions: 1.6.7, 1.8
> Reporter: Dirk Rudolph
> Assignee: Vikas Saurabh
> Labels: excerpt
>
> The change made here:
> https://github.com/apache/jackrabbit-oak/commit/00c94b71293abcae6d76bb162c3f55c7d09b702e#diff-d4bdf443c61f24b634f33aab607e2114
> breaks the logic in line 676:
> {{else if (oakPropertyName.equals(QueryConstants.REP_EXCERPT + "("))}}
> This statement doesn't make much sense considering a query like {{select
> \[rep:excerpt] from \[test:Page] as page where contains(\*, 'term\*')}} or
> even {{select \[rep:excerpt(text)] from \[test:Page] as page where
> contains(page.\[text], 'term\*')}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
